Error on validating-webhook manifest

Bugs
1

Hi,
on codefresh argo-events repo there is an error.

Without this config, the events-webhook container won’t start.

Existing config :
kind: ClusterRole
metadata:
name: argo-events-webhook
rules:
…

  • apiGroups:
    • apps
      resources:
    • deployments/finalizers
    • clusterroles/finalizers
      verbs:
    • update

Expected config :
kind: ClusterRole
metadata:
name: argo-events-webhook
rules:
…

  • apiGroups:
    • apps
      resources:
    • deployments/finalizers
      verbs:
    • update
  • apiGroups:
2

To clarify, the error I encounter is on openshift 4.12 (kubernetes 1.25)

3

Hello

It would be great if you could open a PR with the fix so that our team can review/merge it.

4

Hello,

thanks, how can i do to contribute to argo-events repo ?
I can’t create a new branch to push my commit.

I’m not used to using git, so I can miss something but without that I can’t create a PR ?

5

You need to fork the repository first in your own account. Then create a branch there, and finally a PR against the original repo

6

Hello,

Sorry but it seems that i can’t create a PR too :

Can't create a new pull request: Push failed: remote: Permission to codefresh-io/argo-events.git denied to bizalu.
7

Hey

codefresh-io/argo-events.git is our own repo

You need to create a PR from a branch that exists in YOUR repo (it should be something like github.com/bizalu/argo-events.git

What is the URL of your repo? It should be public if you want to create a PR

You can always consult the Github docs Fork a repo - GitHub Docs
Creating a pull request from a fork - GitHub Docs